Added better user configuration and removed extra logging

src/api/routes/webhooks/#webhook_id/index.ts

@@ -180,19 +180,19 @@ router.patch(
 					where: { id: channel_id },
 				}),
 			});
-		console.log(webhook.channel_id);
 
-		await webhook.save();
+		await Promise.all([
-		await emitEvent({
+			webhook.save(),
+			emitEvent({
 				event: "WEBHOOKS_UPDATE",
 				channel_id,
 				data: {
 					channel_id,
 					guild_id: webhook.guild_id,
 				},
-		} as WebhooksUpdateEvent);
+			} as WebhooksUpdateEvent),
+		]);
 
-		console.log(webhook.channel_id);
 		res.json(webhook);
 	},
 );

src/util/config/Config.ts

@@ -37,6 +37,7 @@ import {
 	SecurityConfiguration,
 	SentryConfiguration,
 	TemplateConfiguration,
+	UserConfiguration,
 } from "../config";
 
 export class ConfigValue {
@@ -61,4 +62,5 @@ export class ConfigValue {
 	email: EmailConfiguration = new EmailConfiguration();
 	passwordReset: PasswordResetConfiguration =
 		new PasswordResetConfiguration();
+	user: UserConfiguration = new UserConfiguration();
 }

src/util/config/types/UsersConfiguration.ts

@@ -0,0 +1,22 @@
+/*
+	Spacebar: A FOSS re-implementation and extension of the Discord.com backend.
+	Copyright (C) 2023 Spacebar and Spacebar Contributors
+	
+	This program is free software: you can redistribute it and/or modify
+	it under the terms of the GNU Affero General Public License as published
+	by the Free Software Foundation, either version 3 of the License, or
+	(at your option) any later version.
+	
+	This program is distributed in the hope that it will be useful,
+	but WITHOUT ANY WARRANTY; without even the implied warranty of
+	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+	GNU Affero General Public License for more details.
+	
+	You should have received a copy of the GNU Affero General Public License
+	along with this program.  If not, see <https://www.gnu.org/licenses/>.
+*/
+
+export class UserConfiguration {
+	blockedContains: string[] = ["discord", "clyde", "spacebar"];
+	blockedEquals: string[] = ["everyone", "here"];
+}

src/util/config/types/index.ts

@@ -37,3 +37,4 @@ export * from "./SecurityConfiguration";
 export * from "./SentryConfiguration";
 export * from "./subconfigurations";
 export * from "./TemplateConfiguration";
+export * from "./UsersConfiguration";

src/util/util/NameValidation.ts

@@ -30,8 +30,8 @@ export function ValidateName(name: string) {
 			},
 		});
 	}
-
+	const general = Config.get();
-	const { maxUsername } = Config.get().limits.user;
+	const { maxUsername } = general.limits.user;
 	if (check_username.length > maxUsername || check_username.length < 2) {
 		throw FieldErrors({
 			username: {
@@ -41,11 +41,17 @@ export function ValidateName(name: string) {
 		});
 	}
 
-	const blockedContains = ["discord", "clyde", "spacebar"];
+	const { blockedContains, blockedEquals } = general.user;
 	for (const word of blockedContains) {
 		if (name.toLowerCase().includes(word)) {
 			throw new HTTPError(`Username cannot contain "${word}"`, 400);
 		}
 	}
+
+	for (const word of blockedEquals) {
+		if (name.toLowerCase() === word) {
+			throw new HTTPError(`Username cannot be "${word}"`, 400);
+		}
+	}
 	return name;
 }