Dekescordes/spacebar
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't fetch the entire role relation when counting member ids

Browse Source
This commit is contained in:
Madeline 2023-04-11 13:17:51 +10:00
parent e9ce4ca51b
commit 7a2a41be3e
No known key found for this signature in database
GPG Key ID: 1958E017C36F2E47
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/api/routes/guilds/#guild_id/roles/#role_id/member-ids.ts
View File

@ -24,17 +24,19 @@ const router = Router();
router.get("/", route({}), async (req: Request, res: Response) => { router.get("/", route({}), async (req: Request, res: Response) => {
const { guild_id, role_id } = req.params; const { guild_id, role_id } = req.params;
await Member.IsInGuildOrFail(req.user_id, guild_id);
// TODO: Is this route really not paginated?
const members = await Member.find({ const members = await Member.find({
select: ["id"], select: ["id"],
relations: ["roles"], where: {
roles: {
id: role_id,
},
guild_id,
},
}); });
const member_ids = members
.filter((member) => { return res.json(members.map((x) => x.id));
return member.roles.map((role) => role.id).includes(role_id);
})
.map((member) => member.id);
return res.json(member_ids);
}); });
export default router; export default router;