Dekescordes/spacebar
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

GuildMemberPatch: remove a useless query

Browse Source
This commit is contained in:
Puyodead1 2023-12-14 09:36:40 -05:00
parent 0a6f6a095d
commit a574284e9f
No known key found for this signature in database
GPG Key ID: A4FA4FEC0DD353FC
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/api/routes/guilds/#guild_id/members/#member_id/index.ts
View File

@ -113,9 +113,6 @@ router.patch(
relations: ["roles", "user"], relations: ["roles", "user"],
}); });
const permission = await getPermission(req.user_id, guild_id); const permission = await getPermission(req.user_id, guild_id);
const everyone = await Role.findOneOrFail({
where: { guild_id: guild_id, name: "@everyone", position: 0 },
});
if ("nick" in body) { if ("nick" in body) {
permission.hasThrow("MANAGE_NICKNAMES"); permission.hasThrow("MANAGE_NICKNAMES");
@ -152,15 +149,14 @@ router.patch(
body.roles = body.roles || []; body.roles = body.roles || [];
body.roles.filter((x) => !!x); body.roles.filter((x) => !!x);
if (body.roles.indexOf(everyone.id) === -1) if (body.roles.indexOf(guild_id) === -1) body.roles.push(guild_id);
body.roles.push(everyone.id);
// foreign key constraint will fail if role doesn't exist // foreign key constraint will fail if role doesn't exist
member.roles = body.roles.map((x) => Role.create({ id: x })); member.roles = body.roles.map((x) => Role.create({ id: x }));
} }
await member.save(); await member.save();
member.roles = member.roles.filter((x) => x.id !== everyone.id); member.roles = member.roles.filter((x) => x.id !== guild_id);
// do not use promise.all as we have to first write to db before emitting the event to catch errors // do not use promise.all as we have to first write to db before emitting the event to catch errors
await emitEvent({ await emitEvent({